Update padding of govuk-main-wrapper #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1073
NickColley
reviewed
Nov 21, 2018
CHANGELOG.md
Outdated
| @@ -12,6 +12,12 @@ | |||
|
|
|||
| ([PR #N](https://github.com/alphagov/govuk-frontend/pull/N)) | |||
|
|
|||
| - Update padding of govuk-main-wrapper | |||
There was a problem hiding this comment.
I'm not 100% sure this is a breaking change, but we have not really figured out if rhythm changes should count as a breaking change...
|
@dashouse I've had another look at this, I think we could ship this as a fix, I'm not sure it's risky enough to be a breaking change. |
36degrees
approved these changes
Mar 8, 2019
|
Will update the branch... |
NickColley
force-pushed
the
increase-padding-on-main-wrapper
branch
from
86e8574
to
026848a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion on the GOV.UK Design System Backlog (alphagov/govuk-design-system-backlog#64 (comment)) I looked into the spacing above the h1 to make it equal with the spacing underneath, which is more inline with GOV.UK.
I have made a manual adjustment that increases the padding of
govuk-main-wrapperby 10px on tablet and up only.From:
30px tablet and up > 20px mobile
To:
40px tablet and up > 20px mobile
This breaks the responsive spacing scale intentionally as we are looking to replicate the margin of
govuk-heading-xl(50px > 30px) whilst accommodating the margin-bottom / white space of the the back link / breadcrumbs (~10px).From tablet, 40px padding-top on
govuk-main-wrapper+ 10px margin-bottom of back link = 50px.On mobile, 20px padding-top on
govuk-main-wrapper+ 10px margin-bottom of back link = 30pxThis now equals
govuk-heading-xl(50px > 30px)Before (GOV.UK | GOV.UK Frontend)
After (GOV.UK | GOV.UK Frontend)
