Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 5px bottom margin to bullet-less list items #1078

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Add 5px bottom margin to bullet-less list items #1078

merged 2 commits into from
Nov 26, 2018

Commits on Nov 22, 2018

  1. Add 5px bottom margin to bullet-less list items 

    On small screens list items have no bottom margin (with a 5px bottom margin being applied at tablet and above)

When the govuk-list class is applied on it's own without any modifier, the <li>'s appear to run into each other on mobile, as the spacing between the list items is the same as the spacing between each line.

(When a bullet or number modifier is added e.g. class="govuk-list govuk-list--bullet" the bullet or number indicates the start of a new list item, so the spacing does not need to be adjusted in that case.)

This change applies the spacing to the govuk-list class for all breakpoints, then adjusts the behaviour when bullet or number modifiers are added.

Co-authored-by: David House <david.house@digital.cabinet-office.gov.uk>
    @36degrees
    36degrees and David House committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    729f41b View commit details
    Browse the repository at this point in the history

  2. Document in CHANGELOG

    @36degrees
    36degrees committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    987a98f View commit details
    Browse the repository at this point in the history