Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports from Character Count #1087

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

36degrees
Copy link
Contributor

The error message, hint and label are all handled by the textarea component which we call from the character count, so there is no need to import them separately.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1087 December 11, 2018 09:17 Inactive
The error message, hint and label are all handled by the textarea component which we call from the character count, so there is no need to import them separately.
Copy link
Contributor

@aliuk2012 aliuk2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot 👍

@36degrees 36degrees merged commit 7c46b5e into master Dec 11, 2018
@36degrees 36degrees deleted the remove-unused-imports-character-count branch December 11, 2018 09:35
@NickColley NickColley added this to the [NEXT] milestone Dec 11, 2018
@NickColley NickColley mentioned this pull request Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants