Add desktop specific grid classes #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1094
|
I'm going to test this alongside the new component with Dave to check we're happy with all of this. |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1094
|
This was tested as part of #1097 and worked as expected |
NickColley
approved these changes
Jan 9, 2019
NickColley
approved these changes
Jan 9, 2019
These classes allow users to create more advanced layouts, such as used in the ‘check answers’ pattern, where the list of answers users the entire width at tablet, but is restricted to the left two-thirds on desktop. There may be a need for breakpoint constrained classes in the future (for example, an `at-tablet` class which applies only whilst within the tablet breakpoint) so we’re using `-from-` to signify that the class applies at desktop _and above_.
36degrees
force-pushed
the
add-desktop-grid-classes
branch
from
3ca3108
to
d578996
Compare
|
Updated with a changelog entry. |
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #1041 and builds on work done in #1090.
These classes allow users to create more advanced layouts, such as used in the ‘check answers’ pattern, where the list of answers users the entire width at tablet, but is restricted to the left two-thirds on desktop.
There may be a need for breakpoint constrained classes in the future (for example, an
at-tabletclass which applies only whilst within the tablet breakpoint) so we’re using-from-to signify that the class applies at desktop and above.Closes #1115