Fix container not being centered in IE8 #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1147
NickColley
force-pushed
the
fix-centering-container-ie8
branch
from
e5788c6
to
101903a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1147
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1147
NickColley
force-pushed
the
fix-centering-container-ie8
branch
from
722c9d4
to
9754239
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1147
NickColley
force-pushed
the
fix-centering-container-ie8
branch
from
9754239
to
869ded1
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1147
NickColley
changed the title
NickColley
force-pushed
the
fix-centering-container-ie8
branch
from
869ded1
to
33691f0
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1147
|
I tried to reorder the CSS desktop first but SassMQ smushes 'desktop' media queries into the output CSS which stops that from working... In the future if we decide to drop IE8 we might consider changing this to be desktop first and avoid that behaviour in sass mq |
NickColley
force-pushed
the
fix-centering-container-ie8
branch
from
33691f0
to
9172433
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1147
36degrees
approved these changes
Jan 17, 2019
src/objects/_width-container.scss
Outdated
| // On mobile, add half width gutters | ||
| margin: 0 $govuk-gutter-half; | ||
|
|
||
There was a problem hiding this comment.
unintentional whitespace changes?
NickColley
force-pushed
the
fix-centering-container-ie8
branch
from
9172433
to
acec7fc
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1147
Since the header and the footer component use this container it also fixes centering for these components.
NickColley
force-pushed
the
fix-centering-container-ie8
branch
from
acec7fc
to
52f3ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows browsers that do not support media queries to be centered without a separate stylesheet.
Since the header and the footer component use this container it also fixes centering for these components.
Fixes #1145
Screenshots
Before
After