Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent summary list from wrapping mid-word for most browsers #1185

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Prevent summary list from wrapping mid-word for most browsers #1185

merged 2 commits into from
Feb 15, 2019

Commits on Feb 14, 2019

  1. Prevent summary list from wrapping mid-word 

    [PR alphagov#1169](alphagov#1169) added in some CSS:
- ``word-break: break-word;``, followed by
- ``word-break: break-all;``

``word-break: break-word;`` is the favoured behaviour, but isn't fully supported.
``word-break: break-all;`` is the fallback behaviour, it sometimes results in unfavourable wrapping mid-word.

The order for this CSS needs to be changed to, otherwise the less favourable `break-all` takes precedence.
```CSS
word-break: break-all;
word-break: break-word;
```

**caniuse** said:
> Chrome, Safari and other WebKit/Blink browsers also support the unofficial break-word value

The implication here being that it is not fully supported, so ``word-break: break-all;`` is still needed as a fallback.

Discussed with [Colin Rotherham](https://github.com/colinrotherham)
    @MalcolmVonMoJ @NickColley
    MalcolmVonMoJ authored and NickColley committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    bda9fff View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @MalcolmVonMoJ @NickColley
    MalcolmVonMoJ authored and NickColley committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    139165e View commit details
    Browse the repository at this point in the history