Rename border-width-mobile to reflect how it's used #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1287
hannalaakso
force-pushed
the
amend-border-width-variable
branch
from
b5e64f2
to
fcc1289
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1287
hannalaakso
changed the title
NickColley
reviewed
Apr 30, 2019
NickColley
approved these changes
Apr 30, 2019
hannalaakso
force-pushed
the
amend-border-width-variable
branch
from
fcc1289
to
cdf001d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1287
Despite its name, the variable isn't used on mobile. Standardise the border width on error summary on mobile to use the standard border width. From @dashouse): "The 4px border is used in the conditional reveals because it has to be an even number in order to be centred under the 40px checkbox or radio. 5px would put it 1px too far left or right and it was noticeable. The error summary change is probably not needed." Fixes #1240
hannalaakso
force-pushed
the
amend-border-width-variable
branch
from
cdf001d
to
845b82b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite its current name, the variable isn't used on mobile.
Standardise the border width on error summary on mobile to use the standard border width.
From @dashouse)
Fixes #1240