Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing of tabs list updated to be more inline with similar lists on GOV.UK and the Design System #1330

Merged
merged 3 commits into from
May 10, 2019
Merged

Spacing of tabs list updated to be more inline with similar lists on GOV.UK and the Design System #1330

merged 3 commits into from
May 10, 2019

Commits on May 10, 2019

  1. Fix poor colour contrast in IE8 for banner

    @hannalaakso
    hannalaakso committed May 10, 2019
    Configuration menu
    Copy the full SHA
    493e442 View commit details
    Browse the repository at this point in the history

  2. Improve tabs heading spacing on mobile and no-js view 

    Split from #1326

This amends the tab headings spacing on mobile and no-js view to be
consistent with how we present the navigation on the Design System:

Adjusts the padding/margin so that with the the list version of component
that’s used on mobile and no-js we use have govuk-spacing(2) as bottom margin,
consistent with what we do with on-page navigation in GOV.UK Design System when
it's displayed as a list. For the desktop/js-enabled version of component remove
bottom margin and use top and bottom padding instead.

Also adjusts bottom margin of list item so that it’s applied on no-js version
and add some more spacing under the tabs title.
    @hannalaakso
    hannalaakso committed May 10, 2019
    Configuration menu
    Copy the full SHA
    794728b View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @hannalaakso
    hannalaakso committed May 10, 2019
    Configuration menu
    Copy the full SHA
    956aba6 View commit details
    Browse the repository at this point in the history