Fix settings layer being implicitly dependant on itself #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1381
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1381
NickColley
force-pushed
the
ensure-all-layers-can-be-imported-individually
branch
from
843bb7f
to
22532e6
Compare
36degrees
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Design System website we rely on being able to compile the colours palette on it's own, but we have found that it no longer defines it's dependencies correctly and instead relies on it implicitly relying on files being included in a certain order.
This pull request ensures all files can be compiled on their own, and fixes any places where they cannot.
It also includes a refactor for the Sass tests to use the jest helper method...
Review commit by commit to avoid the big diff.