Ensure character count message is hidden to assistive technologies when not visible #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1442
NickColley
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1442
36degrees
approved these changes
Jun 12, 2019
We use `visibility` to ensure the character count keeps the same size in the page, but this requires additional work to ensure it's not visible to an assistive technology like a screen reader.
NickColley
force-pushed
the
ensure-character-count-message-is-hidden-when-not-visible
branch
from
71594e6
to
6bc9986
Compare
NickColley
deleted the
ensure-character-count-message-is-hidden-when-not-visible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the threshold feature in the character count component it is possible to access the message when it is visually hidden using a screen reader.
This change makes sure that the visual behaviour is consistent with the screen reader behaviour by hiding the content from the accessibility tree using
aria-hidden.Screen reader testing
Test URL: http://localhost:3000/components/character-count/with-threshold/preview
NVDA 2019 with Firefox 60.7.0esr
When the message first appears it is not announced, but after it is visible any other changes will cause an announcement, for example if another character is entered. I do not think this is a barrier.
JAWS 2018 with Internet Explorer 11
Message is read out as expected
VoiceOver with Safari 12.1.1
Message is read out as expected
Fixes #1406