Make dark grey darker #1827
Merged
Make dark grey darker #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1827
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1827
The palette on the colour page is magically* generated from the Sass, so will automatically change once updated to use the latest version of frontend 💥 * It's not really magic, it's just code, some gaffa tape and crossed fingers |
|
This'll need an entry in the changelog. |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1827
christopherthomasdesign
force-pushed
the
darken-secondary-text
branch
from
326ec43
to
7e760e1
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1827
christopherthomasdesign
force-pushed
the
darken-secondary-text
branch
from
7e760e1
to
3775a1c
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1827
added 2 commits
July 9, 2020 14:21
christopherthomasdesign
force-pushed
the
darken-secondary-text
branch
from
3775a1c
to
579a7c5
Compare
This was referenced Jul 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grey hint text continues to cause issues for users, with many struggling to read it or missing it because it's too pale. For an example see this comment on the text input component.
This PR changes
govuk-colour("dark-grey")from#626a6eto#505a5f. This is the one of the palest greys I could find that meets AAA contrast for body copy:I appreciate we have darkened this grey before and that we probably shouldn't go any darker than this because it'll get so close to being black as to be pointless. This grey has a bit less contrast with the black than before, though I'd argue that this shouldn't affect the usability of form elements for those that can't detect the difference in colour.
This is the simplest change we can make now with the fewest repercussions across the system. If we continue to see problems after this change, we clearly can't make it any darker so will look into an alternative approach like bolding labels and making hint text black.
This change will need to be accompanied by changes to the colour page in the Design System.
Relates to alphagov/govuk-design-system#1222