Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing spellcheck param to character count #1869

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Jul 17, 2020

What

Add missing spellcheck param for the character count component.

Why

We added a new spellcheck param to the textarea component in #1859 However, we forgot to add the param to the character count component, which meant it couldn't be passed through to the textarea.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1869 July 17, 2020 08:59 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1869 July 17, 2020 08:59 Inactive
@vanitabarrett vanitabarrett marked this pull request as ready for review July 17, 2020 09:13
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@vanitabarrett vanitabarrett force-pushed the add-missing-spellcheck-to-char-count branch from 2e65fa2 to 28af5e0 Compare July 17, 2020 10:27
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1869 July 17, 2020 10:27 Inactive
@vanitabarrett vanitabarrett force-pushed the add-missing-spellcheck-to-char-count branch from 28af5e0 to 53e721f Compare July 17, 2020 12:08
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1869 July 17, 2020 12:08 Inactive
@vanitabarrett vanitabarrett force-pushed the add-missing-spellcheck-to-char-count branch from 53e721f to 62d3f94 Compare July 17, 2020 12:13
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1869 July 17, 2020 12:14 Inactive
@vanitabarrett
Copy link
Contributor Author

@36degrees Added tests now - are you ok to re-review please?

@vanitabarrett vanitabarrett force-pushed the add-missing-spellcheck-to-char-count branch from 62d3f94 to 2ea37d4 Compare July 17, 2020 14:38
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1869 July 17, 2020 14:38 Inactive
Vanita Barrett added 2 commits July 17, 2020 15:39
We added a new spellcheck param to the textarea component in #1859

However, we forgot to add the param to the character count component, which meant it couldn't be passed through to the textarea. This adds the missing param.
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants