Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set outline-offset to remove 1px transparent border in chrome v84 #1879

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

rorywilsonros
Copy link
Contributor

Chrome appears to have changed the default outline-offset to 1px, which then adds a transparent border to the skip link. This explicitly sets it to 0 to hide that border.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1879 July 22, 2020 15:43 Inactive
@vanitabarrett
Copy link
Contributor

Hi @rorywilsonros ! Thank you, really speedy work raising this. I'm happy to approve this, just a couple of tidy-up tweaks needed:

  • can you squash the 2 commits into one
  • would you mind adding a CHANGELOG entry (under "fixes") for this change? You can look at other CHANGELOG entries for examples. I'm also happy to add the entry on your behalf, if you'd prefer.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1879 July 23, 2020 08:46 Inactive
@rorywilsonros
Copy link
Contributor Author

Hi @vanitabarrett - thanks for the review and comments. I've squashed the commits, but would prefer you to add the changelog if that's ok? Best

…ome > 84

Chrome 83 appears to have changed the default outline-offset to 1px, which then adds a transparent border to the skip link. This explicitly sets it to 0 to hide that border.

Fix error due to linting rule

removed 'px' for 0 value
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rorywilsonros 🙏🏻

@vanitabarrett vanitabarrett merged commit 2339e8a into alphagov:master Jul 23, 2020
@vanitabarrett vanitabarrett mentioned this pull request Jul 29, 2020
tombye added a commit to alphagov/notifications-admin that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants