Add brand colour for Department for Levelling Up, Housing and Communities (DLUHC) #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DLUHC = Department for Levelling Up, Housing and Communities The colour has a contrast ratio of 14.75, so not adding a websafe colour for this organisation.
brucebolt
added a commit
to brucebolt/govuk-frontend
that referenced
this pull request
Nov 17, 2021
brucebolt
added a commit
to brucebolt/govuk-frontend
that referenced
this pull request
Nov 17, 2021
brucebolt
changed the title
brucebolt
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Nov 17, 2021
DLUHC = Department for Levelling Up, Housing and Communities The colour has a contrast ratio of 14.75, so not adding a websafe colour for this organisation. The same change has been made in [govuk-frontend](alphagov/govuk-frontend#2434), however we need to also make the change here until the next release of govuk-frontend.
brucebolt
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Nov 17, 2021
DLUHC = Department for Levelling Up, Housing and Communities The colour has a contrast ratio of 14.75, so not adding a websafe colour for this organisation. The same change has been made in [govuk-frontend](alphagov/govuk-frontend#2434), however we need to also make the change here until the next release of govuk-frontend.
brucebolt
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Nov 17, 2021
DLUHC = Department for Levelling Up, Housing and Communities The colour has a contrast ratio of 14.75, so not adding a websafe colour for this organisation. The same change has been made in [govuk-frontend](alphagov/govuk-frontend#2434), however we need to also make the change here until the next release of govuk-frontend.
|
Thanks @owenatgov. I don't have permissions to merge on this repo, would you be able to do it for me? |
|
I don't have permissions either sadly. Have prompted the design system team who'll have a look in a bit. |
vanitabarrett
approved these changes
Nov 17, 2021
|
Thanks for raising this @brucebolt - looks good to me. This just needs a second review from someone in the Design System team before it can be merged. |
lfdebrux
approved these changes
Nov 17, 2021
frankieroberto
pushed a commit
to x-govuk/govuk-frontend
that referenced
this pull request
Dec 1, 2021
Merged
alex-ju
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Feb 10, 2022
Temporary added in #2454 this is now available via govuk-frontend alphagov/govuk-frontend#2434
alex-ju
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Feb 14, 2022
Temporary added in #2454 this is now available via govuk-frontend alphagov/govuk-frontend#2434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new department, so adding a new brand colour for this organisation.
Zendesk ticket