Use standalone Sass task (no Gulp) #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3258
1 task
This was referenced Feb 7, 2023
colinrotherham
force-pushed
the
review-app-assets
branch
from
bc69475
to
fc20047
Compare
colinrotherham
force-pushed
the
standalone-sass-task
branch
from
5a94369
to
a41ba5b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3258
colinrotherham
force-pushed
the
review-app-assets
branch
from
fc20047
to
4c42676
Compare
colinrotherham
force-pushed
the
standalone-sass-task
branch
from
a41ba5b
to
fd82eef
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3258
colinrotherham
force-pushed
the
standalone-sass-task
branch
from
fd82eef
to
3fb889b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3258
colinrotherham
force-pushed
the
review-app-assets
branch
2 times, most recently
from
7e009a5
to
d1efb00
Compare
colinrotherham
force-pushed
the
standalone-sass-task
branch
from
3fb889b
to
b16c97b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3258
colinrotherham
force-pushed
the
review-app-assets
branch
from
d1efb00
to
211ec3b
Compare
colinrotherham
force-pushed
the
standalone-sass-task
branch
from
b16c97b
to
46bf45f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3258
Merged
colinrotherham
force-pushed
the
review-app-assets
branch
from
211ec3b
to
79f0104
Compare
colinrotherham
force-pushed
the
standalone-sass-task
branch
from
46bf45f
to
e629344
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3258
1 task
colinrotherham
force-pushed
the
review-app-assets
branch
from
79f0104
to
adfc78b
Compare
colinrotherham
force-pushed
the
standalone-sass-task
branch
from
e629344
to
ffa02d7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3258
colinrotherham
added
dependencies
domoscargin
approved these changes
Feb 15, 2023
tasks/compile-stylesheets.mjs
Outdated
|
|
||
| // Resolve @imports via | ||
| includePaths: [ | ||
| join(paths.src, 'govuk'), |
There was a problem hiding this comment.
Let's take this line out, just in case it causes something unexpected to happen - can always review later.
There was a problem hiding this comment.
All sorted, yep happy to wait. Thank you 👍
tasks/compile-stylesheets.mjs
Outdated
|
|
||
| // Resolve @imports via | ||
| includePaths: [ | ||
| join(paths.src, 'govuk'), |
Preparation work to remove Vinyl file objects (used by Gulp) and follow the PostCSS config options: https://github.com/postcss/postcss-load-config#options * Allows `postcss-cli` to work * Keeps webpack file string compatibility
colinrotherham
force-pushed
the
standalone-sass-task
branch
from
ffa02d7
to
5759251
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses
gulp-sassnot supporting the Dart Sass modern compilation APIIt moves our Sass
compile:scsstask into a separate file but also:compileStylesheet()helper ready for deprecation log filteringIt follows the same approach we took for Rollup:
Due to
gulp-postcsswe haven't been able to follow the PostCSS config optionshttps://github.com/postcss/postcss-load-config#options
These changes now show a clear
from→toconfig for each stylesheetPackages removed include:
Ticks off some tasks from:
But primarily helps unblock: