Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility-mode mixin #3602

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

owenatgov
Copy link
Contributor

What/Why

Removes the public and private compatibility mode sass mixin (compatibility-mode and _compatibility-mode respectively), the private mixins use in the codebase and tests associated with the mixin.

Resolves #2793

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3602 May 10, 2023 11:46 Inactive
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tidy! Assuming this will be covered by the changelog entry from #3583 and so doesn't need one now.

@@ -23,7 +23,6 @@ groups:
settings/warnings: Settings / Warnings
tools: Tools
tools/assets: Tools / Assets
tools/compatibility-mode: Tools / Compatibility Mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done for spotting this – a thorough clean up

Copy link
Member

@querkmachine querkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was also just looking through this, so have a second approval for good luck.

@owenatgov owenatgov merged commit f4d0533 into main May 11, 2023
@owenatgov owenatgov deleted the remove-compatibility-mode-mixin branch May 11, 2023 09:00
@romaricpascal romaricpascal mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove govuk-compatibility mixin from codebase
4 participants