Remove JavaScript from Details component #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
approved these changes
Jun 8, 2023
|
@domoscargin what needs to be done to get this out of draft / mergeable? 🙂 |
|
@36degrees I was waiting till #3758 is ready, since merging this PR will create the styling issue with older browsers which aren't polyfilled. Otherwise we could take the view that we're going to merge #3758 shortly anyway, and get this one merged sooner? Happy either way. |
|
@domoscargin How about I merge the ES2015 classes first in #3771 but then rebase this branch for you, avoiding any conflicts? |
|
@colinrotherham Was just opening this up to do a rebase, but since you're close to the work, go ahead! |
colinrotherham
force-pushed
the
bk-details-js
branch
from
857bc20
to
a5f2bf6
Compare
|
@domoscargin Rebased this one + #3758 |
domoscargin
force-pushed
the
bk-details-js
branch
from
a5f2bf6
to
484aed0
Compare
EdgeHTML is the only browser engine that supports `-ms-ime-align`, so we can check Edge 12 - 18 by applying this property. https://browserstrangeness.github.io/css_hacks.html We can target Edge 16 - 18 more specifically, but keeping it simple for now. This approach just wraps almost everything in a check to see the browser DOESN'T support `-ms-ime-align`, but separates some spacing and border styles to make things look tolerable.
domoscargin
force-pushed
the
bk-details-js
branch
from
91a5522
to
0d35415
Compare
36degrees
added a commit
that referenced
this pull request
Nov 9, 2023
This example was used to test the JavaScript polyfill for the details component on a `<div>` to ensure that it added the same functionality as the native `<details>` element. We removed that JavaScript polyfill in #3766. This example no longer functions correctly (it renders something that looks like the details component, but clicking the summary does not open or close) and serves no purpose, so we can remove it.
querkmachine
pushed a commit
that referenced
this pull request
Nov 13, 2023
This example was used to test the JavaScript polyfill for the details component on a `<div>` to ensure that it added the same functionality as the native `<details>` element. We removed that JavaScript polyfill in #3766. This example no longer functions correctly (it renders something that looks like the details component, but clicking the summary does not open or close) and serves no purpose, so we can remove it.
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3464