[support/4.x] Backport: Run GitHub Actions tests on Windows #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
force-pushed
the
tests-on-windows-4.x
branch
from
62021c8
to
8c81b10
Compare
|
Maybe need #3584 too? |
colinrotherham
force-pushed
the
tests-on-windows-4.x
branch
from
8c81b10
to
2a1d9dd
Compare
colinrotherham
changed the base branch from
support/4.x
to
backport-fix-helpers-windows
colinrotherham
force-pushed
the
backport-fix-helpers-windows
branch
from
afc81a9
to
c49196d
Compare
colinrotherham
force-pushed
the
tests-on-windows-4.x
branch
from
2a1d9dd
to
b22a76e
Compare
colinrotherham
force-pushed
the
backport-fix-helpers-windows
branch
from
c49196d
to
7c85d71
Compare
colinrotherham
force-pushed
the
tests-on-windows-4.x
branch
from
b22a76e
to
6f5435b
Compare
We needed to backport a few more changes in: |
colinrotherham
force-pushed
the
backport-fix-helpers-windows
branch
from
7c85d71
to
f4c451c
Compare
colinrotherham
force-pushed
the
tests-on-windows-4.x
branch
from
6f5435b
to
4ee3e88
Compare
|
@colinrotherham thanks for looking into those and for rebasing this for me 🙌🏻 |
|
One more PR to go and this one's ready to go: |
colinrotherham
force-pushed
the
backport-fix-helpers-windows
branch
from
f4c451c
to
012c3e6
Compare
colinrotherham
force-pushed
the
tests-on-windows-4.x
branch
from
4ee3e88
to
bbfc6bc
Compare
colinrotherham
changed the title
colinrotherham
force-pushed
the
tests-on-windows-4.x
branch
from
bbfc6bc
to
dc60ccf
Compare
romaricpascal
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of @colinrotherham's changes in #3955 to the
support/4.xbranch.It's currently not possible to merge pull requests based off of the
support/4.xbranch (like #3990) because the Windows tests are set up as required status checks but GitHub Actions is not configured to run them.This PR updates our GitHub Actions tests to run on both Ubuntu and Windows:
Only Ubuntu runs Percy screenshots and Node.js package export tests
Branch protection status checks will need updating to include the runnerUpdate 1: Thankfully looks like GitHub ignores the(${{ matrix.runner }})at the end of the status check nameUpdate 2: Unfortunately re-running the checks now shows status check renames will be needed