Add adjecent styles for headings after lists #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-408
|
Worth ensuring there's an example for this on the typography example page? |
|
@36degrees Updated |
hannalaakso
reviewed
Jan 3, 2018
| @@ -139,14 +139,17 @@ | |||
| } | |||
|
|
|||
| .govuk-body-m + .govuk-heading-l, | |||
| .govuk-body-s + .govuk-heading-l { | |||
| .govuk-body-s + .govuk-heading-l, | |||
There was a problem hiding this comment.
Does this rule somehow relate to lists?
There was a problem hiding this comment.
The only thing that's changed is the opening parenthesis has been changed to a comma to allow the extra selectors to be added to the list…
There was a problem hiding this comment.
So it has, I must be tired 😅
| .govuk-body-m + .govuk-heading-s, | ||
| .govuk-body-s + .govuk-heading-s { | ||
| .govuk-body-s + .govuk-heading-s, |
There was a problem hiding this comment.
Similar here, does this relate to lists styling?
hannalaakso
approved these changes
Jan 3, 2018
This was referenced Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds padding to the top of headings that follow a list
https://trello.com/c/KZx3SKjW/543-ul-and-ol-contextual-spacing