Make buttons 40px high including box shadow #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects the button height to 40px including the shadow, which means it lines up correctly with other form components.
Because the shadow is considered 'part of' the button but is actually included as part of the margin, we need to increase the bottom margin to compensate. This also adds a comment to try and explain what on earth is going on.
This ensures that the button will be 40px high at all breakpoints, whilst the font size only (of the button's text) will be reduced on mobile.
|
How should the buttons align? At the moment they're different height to the input, is that intended? |
|
They should align on desktop and mobile, but at the minute they only align on desktop. Mobile will follow once https://trello.com/c/WpPKyqxl/493-define-size-of-inputs-etc-in-pixels-rather-than-em is done as inputs and buttons will all be 40px high at all breakpoints. |
NickColley
approved these changes
Jan 9, 2018
This was referenced Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the shadow is visually 'part of' the button, we need to reduce the height of the button to compensate by adjusting its padding and increase the bottom margin to include it.
We also fix the line height at 40px which means that whilst the button font size reduces on a mobile breakpoint, the height of the element remains the same. This means that when we remove the use of
emfor the inputs we will end up with inputs and buttons having a consistent height of 40px at all breakpoints.Until the use of
emfor inputs is removed, this currently looks worse on mobile because the inputs become shorter but the button now does not.Desktop
Before
After
Mobile
Before
After
https://trello.com/c/03CyckKm/488-correct-button-height