Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw ElementError when the menu of the header is missing but a toggle is present #4206

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Throw ElementError when the menu of the header is missing but a toggle is present #4206

merged 3 commits into from
Sep 22, 2023

Commits on Sep 22, 2023

  1. Throw an ElementError when the menu of the header is absent. 

    We need to keep the early return if the toggle is absent, as it's not mandatory for the header
to have a navigation.

It could be good useful to expand the validations a little there and verify:
- the presence of an `aria-controls` attribute on the `$menuButton`
- the case where a menu is present, but no toggle

This is outside of the scope of this PR, whose aim is to throw where v4 would return early.

Closes #4130
    @romaricpascal
    romaricpascal committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    9b7b370 View commit details
    Browse the repository at this point in the history

  2. Align how we access the menu element with the checkboxes and radios 

    See: 266f877
    @romaricpascal
    romaricpascal committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d41d913 View commit details
    Browse the repository at this point in the history

  3. Fix identifiers of ElementErrors being thrown

    @romaricpascal
    romaricpascal committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    827ba90 View commit details
    Browse the repository at this point in the history