Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTML validation rules for missing elements #4417

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Add HTML validation rules for missing elements #4417

merged 5 commits into from
Nov 20, 2023

Commits on Nov 10, 2023

  1. Add HTML validation for Nunjucks page template

    @colinrotherham
    colinrotherham committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    240fbe9 View commit details
    Browse the repository at this point in the history

  2. Add HTML validation rules for missing elements 

    See new rules:

* https://html-validate.org/rules/input-missing-label.html
* https://html-validate.org/rules/no-missing-references.html
    @colinrotherham
    colinrotherham committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    6e03bf1 View commit details
    Browse the repository at this point in the history

  3. Update test target to id="test-target-element" 

    See comments on: #4417 (comment)
    @colinrotherham
    colinrotherham committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    9a9929d View commit details
    Browse the repository at this point in the history

  4. Add element id="test-target-element" for HTML validation 

    We previously enabled the rule `no-missing-references` but lots of examples target `id="test-target-element"` on the preview container which isn’t available when only the component is rendered

For example from fieldset.yaml

```
  - name: with describedBy
    hidden: true
    options:
      describedBy: test-target-element
      legend:
        text: Which option?
```
    @colinrotherham
    colinrotherham committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    3286939 View commit details
    Browse the repository at this point in the history

  5. Add element id="test-target-element" for accessibiilty tests

    @colinrotherham
    colinrotherham committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    f4f16a0 View commit details
    Browse the repository at this point in the history