Add govuk-section-break to core #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-483
NickColley
reviewed
Jan 30, 2018
| @@ -48,5 +48,10 @@ | |||
| a { | |||
| @extend .govuk-link; | |||
| } | |||
|
|
|||
| hr { | |||
There was a problem hiding this comment.
Should this use govuk-section-break__visible ?
There was a problem hiding this comment.
Can we also add an example to the prose page to show this in use?
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-483
dashouse
force-pushed
the
section-break
branch
from
17edfaf
to
ed4fa6f
Compare
dashouse
changed the title
|
After update, this looks technically good to me. Happy to approve if no one else wants to raise any questions. |
|
This looks good to me too. Have just updated Changelog. @alex-ju if you're happy with the changelog could you approve 🙂 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there is a need to visually separate parts of a page on top of the existing typographic hierarchy.
This class is added to an
<hr>, adds margin (xl, l and m).There is also an option to make the
<hr>border visible or invisible.##Examples
Not visible
###Visible
Example usage
The section below the Start button on a start page is achieved by adding margin to the Start button.
This conceptually feels like a new section of the page.
Related
How this might work with
<section>As part of https://trello.com/c/8LRu4psv/515-add-styling-for-horizontal-rules