Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result of calculation #4951

Closed
wants to merge 1 commit into from

Conversation

Nepomuceno
Copy link

Helps with
#2238

Putting the result of the calculation using a quite close approximation for results that endup not being a whole number.

@owenatgov
Copy link
Contributor

Hi @Nepomuceno. Sorry we've taken ages to repond to this.

The transition path for this is to move to the Dart Sass module system, which we cannot do yet as Frontend still supports teams that are using Ruby Sass and LibSass—for which there is no alternative syntax.

Although the examples changed here don't see to have any side effects, there are about 40 more instances of / for division elsewhere in our Sass. I appreciate this is just trying to help, but we'd rather solve the problem holistically if we're able to. We're planning to move to the Dart Sass module system fairly soon, so our intent is to resolve all of them at once when we're able.

In the meantime, you can silence any warnings you're receiving from govuk-frontend by using the quietDeps option in your Sass build configuration or using the --quiet-deps command line flag.

@owenatgov owenatgov closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants