Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message tests #507

Merged
merged 4 commits into from
Feb 7, 2018
Merged

Add error message tests #507

merged 4 commits into from
Feb 7, 2018

Conversation

36degrees
Copy link
Contributor

Add tests for the error message component, and also fix the indentation of the template.

https://trello.com/c/oZODoOUh/658-automated-tests-for-error-message-component

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-507 February 6, 2018 16:18 Inactive
Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 apart from the failing Travis build

@36degrees
Copy link
Contributor Author

Re-running.

@36degrees
Copy link
Contributor Author

Just realised there was no changelog entry - @igloosi you happy with that last commit?

@kr8n3r
Copy link

kr8n3r commented Feb 7, 2018

yep all good.

@36degrees 36degrees merged commit 263ffb6 into master Feb 7, 2018
@36degrees 36degrees deleted the add-error-message-tests branch February 7, 2018 09:32
@alex-ju alex-ju mentioned this pull request Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants