Fix non-semantic use of text colour for borders. #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the minute we are using the `$govuk-text-colour` variable for the colour of form control borders, which doesn’t make much sense semantically. This introduces a new variable, `$govuk-input-border-colour` which is set to the same `$govuk-black` that `$govuk-text-colour` currently refers to, and updates form components to use it for the border colour.
This matches the existing behaviour in Elements and the behaviour of the equivalent pseudo element in the Radios component.
We want to use currentColor which is the default value but as users are likely used to seeing the colour defined as part of the shorthand border property being explicit makes it less likely someone will try and ‘fix’ this by adding another colour.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-551
|
looking good, just the changelog |
kr8n3r
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the minute we are using the
$govuk-text-colourvariable for the colour of form control borders, which doesn’t make much sense semantically.This introduces a new variable,
$govuk-input-border-colourwhich is set to the same$govuk-blackthat$govuk-text-colourcurrently refers to, and updates form components to use it for the border colour.It also modifies the radio and checkbox components to consistently use
currentColorfor the pseudo-elements, and be explicit about doing so.