Minor fixes to release process #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-567
kr8n3r
force-pushed
the
minor-fixes-to-release-process
branch
from
2672fb9
to
3490ba8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-567
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-567
kr8n3r
force-pushed
the
minor-fixes-to-release-process
branch
from
95a0139
to
c6dd8f0
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-567
kr8n3r
force-pushed
the
minor-fixes-to-release-process
branch
from
c6dd8f0
to
b0b9dda
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-567
kr8n3r
force-pushed
the
minor-fixes-to-release-process
branch
from
b0b9dda
to
204e2bf
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-567
NickColley
approved these changes
Mar 2, 2018
kr8n3r
force-pushed
the
minor-fixes-to-release-process
branch
from
204e2bf
to
49093ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've found that
prereleaseis automatically triggered when runningnpm run releasewhich don't want to do at the moment, as we want to have a pull request step in between.This PR fixes this by using
pre-releasekeyword to avoid that. Also updates publishing documentation to reflect those changes.Also minor fix to correctly check if logged in to NPM with the correct user.