Create package.json for new components in pre-release step
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-574
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-574
alex-ju
reviewed
Mar 6, 2018
bin/check-and-create-package-json.sh
Outdated
|
|
||
| create_package_json ${D} | ||
|
|
||
| echo "⚠️ Remember to add the 🆕 $COMPONENT_NAME 🆕 component to ALL/package.json\n" |
There was a problem hiding this comment.
should all here be lowercase?
alex-ju
approved these changes
Mar 6, 2018
kr8n3r
force-pushed
the
create-package-json-in-prerelease
branch
from
7d5a689
to
5f05ceb
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-574
kr8n3r
force-pushed
the
create-package-json-in-prerelease
branch
from
5f05ceb
to
513f38a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-574
added 2 commits
March 7, 2018 10:35
If a new component has been added to src it needs a package.json file when it gets copied to packages/ We use to do this manually and our tests that run after `build:packages` task would fail. With this script, when `npm run pre-release` is run, the script will check if any new folders exist in packages after the copy task. If so, it will create a sample package.json file with actual component name, version 0.0.0 and latest version of globals as dependency. It will also remind the developer to amend ALL/package.json file with new dependencies. When developer indicates they have done the above, the script will and the rest of the `npm run pre-release` tasks will run.
kr8n3r
force-pushed
the
create-package-json-in-prerelease
branch
from
513f38a
to
ea1176b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-574
kr8n3r
force-pushed
the
create-package-json-in-prerelease
branch
from
ea1176b
to
e3ce1e0
Compare
kr8n3r
changed the title
prerelease steppre-release step
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a new component has been added to
src, it needs a package.json file when it gets copied topackages/We use to do this manually and our tests that run after
build:packagestask would fail.With this script, when
npm run pre-releaseis run, the script will check if any new folders exist in package after the copy task.If so, it will create a sample package.json file with actual component name, version 0.0.0 and latest version of globals as dependency.
it will also remind the developer to amend
all/package.jsonfile with new dependencies.When developer indicates they have done the above, the script will continue and the rest of the
npm run pre-releasetasks will run.Next new component will be: #569