Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap review app css file in conditional comments #653

Merged
merged 2 commits into from
Apr 13, 2018
Merged

Wrap review app css file in conditional comments #653

merged 2 commits into from
Apr 13, 2018

Conversation

hannalaakso
Copy link
Member

This PR:

  • Wraps the common app.css in conditional comments in the review app layout to stop Internet Explorer 8 downloading both the generic and the IE8 stylesheet
  • Mirrors the change made to our docs
  • Was tested on Chrome (latest), FF (59), Android Galaxy S8 (Chrome, FF), Nexus 5 (Chrome, FF), iPhone 6s (Safari), Windows Phone (Nokia Lumia 630), IE 9-11, IE Edge 16

@hannalaakso
Wrap review app css file in conditional comments
0e3b1ef 
To stop IE8 downloading both the generic and the IE8 stylesheet
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-653 April 12, 2018 16:06 Inactive
36degrees
36degrees approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kr8n3r kr8n3r merged commit 129210b into master Apr 13, 2018
@kr8n3r
Copy link

kr8n3r commented Apr 13, 2018

merging in hanna's absence

@kr8n3r kr8n3r deleted the add-conditional-comments-to-layout branch April 13, 2018 08:23
@kr8n3r kr8n3r mentioned this pull request May 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hannalaakso @kr8n3r @36degrees @govuk-design-system-ci