Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable code syntax highlighting in IE8 #675

Merged
merged 2 commits into from
Apr 27, 2018

Conversation

NickColley
Copy link
Contributor

Prism will throw syntax errors making it hard to test IE8 JavaScript.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-675 April 26, 2018 16:36 Inactive
@kr8n3r
Copy link

kr8n3r commented Apr 27, 2018

code-wise it's all good.
Q: are we ok with IE8 users not getting code styling as prism doesn't support ie8?

@36degrees
Copy link
Contributor

IMO, for the review app, yes.

@NickColley NickColley merged commit 2d71d91 into master Apr 27, 2018
@NickColley NickColley deleted the disable-prisim-on-older-browsers branch April 27, 2018 14:05
@kr8n3r kr8n3r mentioned this pull request May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants