Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -webkit-tap-highlight-color from links #692

Merged
merged 2 commits into from
May 16, 2018

Conversation

hannalaakso
Copy link
Member

This line appears to have been copied from GOV.UK Template link styles to set -webkit-tap-highlight-color to grey after removing it globally. However we are not removing it in html in GOV.UK Frontend so setting the colour here is not necessary.

If we DID want to remove -webkit-tap-highlight-color in FE in the future I think we'd need more evidence that removing it in is a good idea: it improves accessibility as the user gets instant feedback. GOV.UK Template links to this article from 2010 as the reason for removing it. However we haven't come across the problem described in the article when testing GOV.UK Frontend on iOS and the article doesn't give practical examples we could test against.

I also checked the difference between the native iOS -webkit-tap-highlight-color and usingrgba($govuk-black, .3) to see if some benefit could be gained from resetting the colour in links. However as the comment for it says the colour "ever-so-slightly darker than the default" so the difference is minimal.

Trello: https://trello.com/c/UeF2Dex3/572-revisit-tap-highlighting-overrides-in-govuk-frontend

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-692 May 11, 2018 10:42 Inactive
@hannalaakso hannalaakso changed the title Remove -webkit-tap-highlight-color in links Remove -webkit-tap-highlight-color from links May 16, 2018
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-692 May 16, 2018 08:24 Inactive
@hannalaakso hannalaakso force-pushed the remove-webkit-tap-highlighting branch from 2cd2487 to eb607c7 Compare May 16, 2018 08:27
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-692 May 16, 2018 08:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants