Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set CSS display property to govuk-shape-arrow mixin #701

Merged
merged 1 commit into from
May 22, 2018
Merged

Add option to set CSS display property to govuk-shape-arrow mixin #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ Fixes:
- Update component readme files content
([PR #704](https://github.com/alphagov/govuk-frontend/pull/704))

New features:

- Add option to set CSS display property for govuk-shape-arrow mixin
([PR #701](https://github.com/alphagov/govuk-frontend/pull/701))

## 0.0.29-alpha (Breaking release)

Expand Down
5 changes: 3 additions & 2 deletions src/helpers/_shape-arrow.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@
// @param {Direction} $direction - Direction for arrow: up, right, down, left.
// @param {Base} $base - Length of the triangle 'base' side
// @param {Height} $height - Height of triangle. Omit for equilateral.
@mixin govuk-shape-arrow($direction, $base, $height: null) {
display: block;
// @param {Display} $display - CSS display property of the arrow: block as default
@mixin govuk-shape-arrow($direction, $base, $height: null, $display: block) {
display: $display;

width: 0;
height: 0;
Expand Down