Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with canvas colour bleeding into main review page #741

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Fix issues with canvas colour bleeding into main review page #741

merged 2 commits into from
Jun 4, 2018

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented May 31, 2018 •
edited
Loading

Sets the canvas colour to the body colour on review app pages, doesnt impact the template examples which do not inherit the _generic template.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-741 May 31, 2018 13:20 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-741 May 31, 2018 13:21 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-741 May 31, 2018 15:59 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-741 May 31, 2018 16:03 Inactive
@NickColley NickColley changed the title Remove template canvas on pages without a header/footer Fix issues with canvas colour bleeding into main review page May 31, 2018
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-741 May 31, 2018 16:05 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-741 May 31, 2018 16:07 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-741 May 31, 2018 16:10 Inactive
@kr8n3r
Copy link

kr8n3r commented May 31, 2018

grey bg on variant preview pages...
why dont we give the <html> a custom app class inside _generic view and reset background colour, to fix all component pages?
template example pages inherit the template directly so they won't be affected

@NickColley
Copy link
Contributor Author

NickColley commented Jun 1, 2018 •
edited
Loading

@igloosi sure, but that felt like a hack, I thought we'd rather have a bit of gray and know how template really works, than having app specific overrides.

This is what people would get if they don't have a header or footer enabled...

Willing to go with the override approach though if that's what people want.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-741 June 1, 2018 16:21 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-741 June 4, 2018 10:24 Inactive
@NickColley
Copy link
Contributor Author

@igloosi updated with your suggestion :)

kr8n3r
kr8n3r approved these changes Jun 4, 2018
View reviewed changes
Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NickColley NickColley merged commit c093695 into master Jun 4, 2018
@36degrees 36degrees deleted the fix-review-app-background branch June 4, 2018 11:52
@hannalaakso hannalaakso mentioned this pull request Jun 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kr8n3r kr8n3r kr8n3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickColley @kr8n3r @govuk-design-system-ci