Refactor Details and Button components #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we encourage users to load their JavaScript before the `<body>` tag, these listeners are not necessary, if a user wants to load GOV.UK Frontend when the page loads. They could wrap their own initialisation of the Details component with a similar listener.
Now if a user chooses only certain details elements will be enhanced.
These are replaced by our polyfills
NickColley
commented
Jun 4, 2018
| // Used to generate a unique string, allows multiple instances of the component without | ||
| // Them conflicting with each other. | ||
| // https://stackoverflow.com/a/8809472 | ||
| export function generateUniqueID () { |
There was a problem hiding this comment.
Is there a simpler version of this?
There was a problem hiding this comment.
It may be a bit of an overkill for what we need, but I get is trying to follow rfc4122, so it should be ok.
NickColley
changed the title
alex-ju
approved these changes
Jun 5, 2018
src/components/details/details.js
Outdated
| // Add ARIA role="group" to details | ||
| details.setAttribute('role', 'group') | ||
| // Save shortcuts to the inner summary and content elements | ||
| $module.__summary = $module.getElementsByTagName('summary').item(0) |
There was a problem hiding this comment.
Not a blocker and I know they were already there, but we're using double underscores only on this component when storing references.
There was a problem hiding this comment.
Forget about that, you already changed it in the next commit.
|
@NickColley Does this need a changelog entry? |
|
@36degrees yeah, I missed that out, sorry :) PR incoming. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Details and Button to match the other components, so they initialise individually.
Best viewed commit by commit
Fixes #666
Testing
Details
Path: /components/details/preview
Tested: click, space and enter
IE8: Works
IE9: Works
IE10: Works
IE11: Works
Edge 17: Works
Firefox 60: Works
Chrome 66: Works
Safari 11.1: Works
Button
Path: /components/button/start-link/preview
Tested: space
IE8: Works
IE9: Works
IE10: Works
IE11: Works
Edge 17: Works
Firefox 60: Works
Chrome 66: Works
Safari 11.1: Works