Calculate font-sizes in rem #858
Merged
Commits on Jul 10, 2018
-
Automatically calculate font-sizes in rem by adding a new setting $govuk-root-font-size, which should match the font-size on the html (root) element.
-
Enabling rem for everyone would make this a breaking change for anyone who is using alphagov/govuk_template or otherwise setting the font-size on their HTML element to anything other than 16px - without them setting `$govuk-root-font-size` this would make their typography the wrong size. We can introduce it as a feature now and enable it by default in the next major release, whilst at the same time changing how the ‘compatibility’ flags work and updating the $govuk-root-font-size setting to set sensible defaults in both cases.
-
Do not set font-size on the html element
Doing this makes it breaks users font-size preferences in some browsers (such as Chrome) – see twbs/bootstrap#19460 for more details. We should instead _assume_ the root font-size is 16px - the point being that if it’s not then the text should adjust accordingly.
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.