Change spacing relationship on default and small legends and hints #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-940
36degrees
reviewed
Aug 3, 2018
| } | ||
|
|
||
| .govuk-fieldset__legend--s { | ||
| @include govuk-font($size: 19, $weight: bold); | ||
| } | ||
|
|
||
| .govuk-fieldset__legend |
There was a problem hiding this comment.
Guessing this change isn't intentional?
dashouse
force-pushed
the
legend-hint-spacing
branch
from
79efb63
to
85b968e
Compare
|
this looks good but it needs a changelog entry as well. is this a bug fix or a new feature? |
NickColley
force-pushed
the
legend-hint-spacing
branch
from
85b968e
to
2b27754
Compare
36degrees
reviewed
Aug 13, 2018
src/components/hint/_hint.scss
Outdated
| // or govuk-fieldset__legend--s for better vertical alignment. | ||
|
|
||
| // This adjustment will not work when the legend is outside the <h1>, however | ||
| // it is unlikely that the default or govuk-fieldset__legend--s class would // be used in this case. |
There was a problem hiding this comment.
This comment's got a mis-placed // – it'd be good to wrap these comments correctly at 80 characters.
kr8n3r
force-pushed
the
legend-hint-spacing
branch
from
2b27754
to
c22b0d0
Compare
|
resolved conflict and comment line length |
36degrees
reviewed
Aug 13, 2018
src/components/hint/_hint.scss
Outdated
|
|
||
| // This adjustment will not work in browsers that do not support :not() | ||
| // Users with these browsers will see the default size margin (5px larger) | ||
| // This adjustment will not work in browsers that do not support :not() Users |
There was a problem hiding this comment.
Can we add a full stop here to keep these sentences from running into each other like this?
kr8n3r
force-pushed
the
legend-hint-spacing
branch
from
c22b0d0
to
e3ee3bd
Compare
… align with labels
kr8n3r
force-pushed
the
legend-hint-spacing
branch
from
e3ee3bd
to
a75c746
Compare
|
merged on behalf of @dashouse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the release of GOV.UK Frontend we changed the spacing of labels and hints when using the default or
govuk-label--sclass. (#806)We chose not update the legend and hint, in isolation they looked good.
However when a service uses a small label + hint and a small legend + hint on the same page the inconsistency is noticeable.
Amending the spacing on the
<legend>is slightly different to the<label>, there was also a need to only reduce spacing on the<legend>when a hint was applied, hence the use of an adjacent selector and negative margin.Before
After
