Allow attributes on checkboxes/radios

[colinrotherham]

Unlike other form controls, the checkbox/radio templates only allow attributes on the wrapping container markup.

Services like ours add data attributes to some checkboxes:

items:
  - value: yes
    text: Yes
    attributes:
      data-example: '123'
  - value: no
    text: No
    attributes:
      data-example: '456'

Following the same pattern as the other input, textarea and select, details templates etc, the attributes are appended like this:

<input ... value="yes" data-example="123">
<input ... value="no" data-example="456">

Hopefully this pull request will help other teams too 😊

[NickColley]

Hey Colin,

Thanks for this!

The general approach seems great, as the addition to items mirrors the attributes approach we use for components.

There are some more house style changes required before we can merge this, let me know if you'd prefer me to do this for you.

This Pull Request will also need to be reviewed and agreed by another member of the team.

[NickColley]

Since this is adding a new feature this changelog entry should be under the feature title.

• https://github.com/alphagov/govuk-frontend/blob/master/CONTRIBUTING.md#updating-changelog

[colinrotherham]

@NickColley No problem, moved it to "New features"

[NickColley]

Not documented, we are trying to only add .yaml examples where we cannot write a unit test for it.

In this case could you remove this example and test that this functionality works by adding a test in checkboxes/template.test.js please?

[colinrotherham]

@NickColley Ah that's fine, makes sense. Added two new tests!

[colinrotherham]

@NickColley I've made those two review changes.

Tests all passing 👍

[colinrotherham]

Updated checkbox/radio readme to document new items.{}.attributes

[NickColley]

Excellent work thanks Colin 👍

We'll need another review from another member of the team.

[dashouse]

Looks good to me 👍