Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow textareas to be resized vertically; set sane minimum height #976

Merged
merged 3 commits into from
Sep 4, 2018

Conversation

36degrees
Copy link
Contributor

@36degrees 36degrees commented Sep 3, 2018

Prevent the textarea component from being resized beyond the bounds of its container, by only allowing it to be resized vertically.

Potential issues for the user are that it would make it difficult or impossible to reduce the width should a click + drag take the textbox beyond the viewport or otherwise overflow hidden regions.

This also makes it less likely that resizing the textarea will cause other issues with the layout of the page.

Fixes #966
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-976 September 3, 2018 15:15 Inactive
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 👍

@36degrees 36degrees merged commit ce47a2f into master Sep 4, 2018
@36degrees 36degrees deleted the textarea-resize branch September 4, 2018 10:05
@NickColley NickColley mentioned this pull request Sep 10, 2018
@kr8n3r kr8n3r added this to the v2.0.0 milestone Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants