Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external links: bump govuk_frontend_toolkit to 5.0.0 and govuk_template to 0.19.0 and govuk_elements_sass to 2.1.0 #302

Merged
merged 3 commits into from
Oct 25, 2016

Conversation

gemmaleigh
Copy link
Contributor

@gemmaleigh gemmaleigh commented Oct 25, 2016

Bump govuk_frontend_toolkit to 5.0.0

This release includes two breaking changes:

  • Removal of external link styles and icons, if you are using the external-link-* mixins you will need to remove them from your codebase (PR #293)
  • Correct spelling of the 'accordion' icon, you will need to check for the incorrect spelling 'accordian' and update if you are using this icon (PR #345)

And two minor changes:

  • Amend GOVUK.StickAtTopWhenScrolling to resize the sticky element and shim when the .js-sticky-resize class is set (PR #343)
  • Allow custom options in GOVUK.analytics.trackPageview (#332)

Bump govuk_template_jinja to 0.19.0


Bump govuk-elements-sass to 2.1.0

@gemmaleigh gemmaleigh changed the title Bump govuk_frontend_toolkit to 5.0.0 Remove external links: bump govuk_frontend_toolkit to 5.0.0 and govuk_template to 0.19.0 Oct 25, 2016
@gemmaleigh gemmaleigh changed the title Remove external links: bump govuk_frontend_toolkit to 5.0.0 and govuk_template to 0.19.0 Remove external links: bump govuk_frontend_toolkit to 5.0.0 and govuk_template to 0.19.0 and govuk_elements_sass to 2.1.0 Oct 25, 2016
This release includes two breaking changes:

Removal of external link styles and icons, if you are using the
external-link-* mixins you will need to remove them from your codebase
(PR #293)
Correct spelling of the 'accordion' icon, you will need to check for
the incorrect spelling 'accordian' and update if you are using this
icon (PR #345)
And two minor changes:

Amend GOVUK.StickAtTopWhenScrolling to resize the sticky element and
shim when the .js-sticky-resize class is set (PR #343)
Allow custom options in GOVUK.analytics.trackPageview (#332)
https://github.com/alphagov/govuk_template/blob/master/CHANGELOG.md

- Remove external link styles (PR #231)
- Remove extraneous copy of HTML5shiv that wasn’t being used (PR #254)
- Update govuk_frontend_toolkit to latest version (PR #256)
https://github.com/alphagov/govuk_elements/blob/master/CHANGELOG.md

Clear floats on details elements (PR #328)
Add a .bold utility class (PR #321)
Remove external link styles (PR #274)
@robinwhittleton
Copy link
Contributor

👍

@robinwhittleton robinwhittleton merged commit b1d3538 into master Oct 25, 2016
@robinwhittleton robinwhittleton deleted the bump-fet-to-5 branch October 25, 2016 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants