Skip to content

Commit

Permalink
Remove external link styles
Browse files Browse the repository at this point in the history
govuk_frontend_toolkit is potentially removing external link styles in alphagov/govuk_frontend_toolkit#293 . If that happens then we’ll want to remove them from govuk_elements as well.
  • Loading branch information
Robin Whittleton committed Sep 7, 2016
1 parent 4ead7fc commit 67ade36
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 20 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ You can pick and chosoe partials from the govuk-elements-sass package.
@import "conditionals"; // Media query mixin
@import "device-pixels"; // Retina image mixin
@import "grid_layout"; // Basic grid layout mixin
@import "typography"; // Core bold and heading mixins, also external links
@import "typography"; // Core bold and heading mixins
@import "shims"; // Inline block mixin, clearfix placeholder

// Mixins to generate components (chunks of UI)
Expand Down
19 changes: 0 additions & 19 deletions public/sass/elements/_govuk-template-base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -124,25 +124,6 @@ a:active {
color: $link-active-colour;
}

// External link styles
// These are currently deprecated and are liable to be removed in a future release.
// If your service has user research that indicates that external links are useful
// (or not) then we’d like to hear from you either on Slack,
// digital-service-designers or opening an issue.
a[rel="external"] {
@include external-link-default;
@include external-link-16;

@include media(tablet) {
@include external-link-19;
}
}

.external-link {
@include external-link-12-no-hover;
@include external-link-heading;
}

// Set focus styles
a {
// Allow RGBA here, this line has been copied from govuk_template
Expand Down

0 comments on commit 67ade36

Please sign in to comment.