Skip to content

Commit

Permalink
Remove external link styles
Browse files Browse the repository at this point in the history
govuk_frontend_toolkit is potentially removing external link styles in alphagov/govuk_frontend_toolkit#293 . If that happens then we’ll want to remove them from govuk_elements as well.
  • Loading branch information
Robin Whittleton committed Jul 13, 2016
1 parent f35558a commit 76e7786
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 21 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ The `_govuk_elements.scss` partial shows which files are required.
@import "conditionals"; // Media query mixin
@import "device-pixels"; // Retina image mixin
@import "grid_layout"; // Basic grid layout mixin
@import "typography"; // Core bold and heading mixins, also external links
@import "typography"; // Core bold and heading mixins
@import "shims"; // Inline block mixin, clearfix placeholder

// Mixins to generate components (chunks of UI)
Expand Down
6 changes: 1 addition & 5 deletions app/views/snippets/typography_links.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,5 @@
<a href="#">A 19px body copy link</a>. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus.
</p>

<p>
<a href="#" rel="external">A 19px body copy external link.</a> Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus.
</p>


<a href="#" class="link-back">Back</a>
<a href="#" class="link-back">Back</a>
15 changes: 0 additions & 15 deletions public/sass/elements/_govuk-template-base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -124,21 +124,6 @@ a:active {
color: $link-active-colour;
}

// External link styles
a[rel="external"] {
@include external-link-default;
@include external-link-16;

@include media(tablet) {
@include external-link-19;
}
}

.external-link {
@include external-link-12-no-hover;
@include external-link-heading;
}

// Set focus styles
a {
// Allow RGBA here, this line has been copied from govuk_template
Expand Down

0 comments on commit 76e7786

Please sign in to comment.