Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove external link styles #274

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Remove external link styles #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ You can pick and chosoe partials from the govuk-elements-sass package.
@import "conditionals"; // Media query mixin
@import "device-pixels"; // Retina image mixin
@import "grid_layout"; // Basic grid layout mixin
@import "typography"; // Core bold and heading mixins, also external links
@import "typography"; // Core bold and heading mixins
@import "shims"; // Inline block mixin, clearfix placeholder

// Mixins to generate components (chunks of UI)
Expand Down
19 changes: 0 additions & 19 deletions public/sass/elements/_govuk-template-base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,25 +122,6 @@ a:active {
color: $link-active-colour;
}

// External link styles
// These are currently deprecated and are liable to be removed in a future release.
// If your service has user research that indicates that external links are useful
// (or not) then we’d like to hear from you either on Slack,
// digital-service-designers or opening an issue.
a[rel="external"] {
@include external-link-default;
@include external-link-16;

@include media(tablet) {
@include external-link-19;
}
}

.external-link {
@include external-link-12-no-hover;
@include external-link-heading;
}

// Set focus styles
a {
// Allow RGBA here, this line has been copied from govuk_template
Expand Down