Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add document level events to selection buttons #139

Merged
merged 9 commits into from
Oct 17, 2014
Merged

Add document level events to selection buttons #139

merged 9 commits into from
Oct 17, 2014

Commits on Oct 12, 2014

  1. Refactor to allow selector strings to be passed in 

    Includes the loss of GOVUK.RadioButtons and GOVUK.CheckboxButtons.
    @tombye
    tombye committed Oct 12, 2014
    Configuration menu
    Copy the full SHA
    a7bd507 View commit details
    Browse the repository at this point in the history

  2. rewrite tests for GOVUK.selectionButtons & add new 

    The old ones were too coupled to the implementation. These are written
to better reflect the behaviours expected.
    @tombye
    tombye committed Oct 12, 2014
    Configuration menu
    Copy the full SHA
    39a3351 View commit details
    Browse the repository at this point in the history

  3. Refactor selection-buttons for readability

    @tombye
    tombye committed Oct 12, 2014
    Configuration menu
    Copy the full SHA
    354bc03 View commit details
    Browse the repository at this point in the history

  4. Add an explanation of the new interface to README.md

    @tombye
    tombye committed Oct 12, 2014
    Configuration menu
    Copy the full SHA
    b9edc08 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2014

  1. Tidy up markSelected method 

    Includes fix for misplaced comma.
    @tombye
    tombye committed Oct 13, 2014
    Configuration menu
    Copy the full SHA
    55cd099 View commit details
    Browse the repository at this point in the history

  2. Change 'bind' prefix to 'add' for all methods

    @tombye
    tombye committed Oct 13, 2014
    Configuration menu
    Copy the full SHA
    2318081 View commit details
    Browse the repository at this point in the history

  3. Merge setEventTypes into addEvents

    @tombye
    tombye committed Oct 13, 2014
    Configuration menu
    Copy the full SHA
    21c07e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2014

  1. Refactor to allow use of GOVUK.SelectionButtons 

    Allows storage of returned instance & for the destroy method (previously
`GOVUK.selectionButtons.removeEventsFor`) to work on that instance.
    @tombye
    tombye committed Oct 14, 2014
    Configuration menu
    Copy the full SHA
    92ee22e View commit details
    Browse the repository at this point in the history

  2. Add documentation for new interface 

    Includes a note on dealing with deprecated functionality.
    @tombye
    tombye committed Oct 14, 2014
    Configuration menu
    Copy the full SHA
    a490c81 View commit details
    Browse the repository at this point in the history