Update to govuk-frontend v4.0.0 with required changes #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move the <button> inside the <nav>, immediately before the <ul> - move the aria-label attribute from the <ul> to the <nav> - move the govuk-header__navigation class from the <ul> to the <nav> - add the govuk-header__navigation-list class to the <ul> As per https://github.com/alphagov/govuk-frontend/releases/tag/v4.0.0
to improve screen reader announcements add a data-module="govuk-skip-link" attribute to the component HTML. Once you've made the changes, check the skip link JavaScript works. To do this, select the skip link and check the linked element (usually the <main> element) in the browser has a tabindex attribute. As per https://github.com/alphagov/govuk-frontend/releases/tag/v4.0.0
Footer should now have grid column classes like ``` <div class="govuk-footer__section govuk-grid-column-two-thirds">...</div> ``` And because offt he dynamic nature, we need to make it configurable in the json, much like https://github.com/alphagov/govuk-frontend/blob/main/src/govuk/components/footer/template.njk#L7 As per https://github.com/alphagov/govuk-frontend/releases/tag/v4.0.0
to stop it appearing in Google Search snippets. As per https://github.com/alphagov/govuk-frontend/releases/tag/v4.0.0
paroxp
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How to test
npm install)npm run build)cdintooutfolder and serve the page (npx serve)localhost:5000for any issuesThere are expected warnings in CSS compilation coming from govuk-frontend
npm installwill output 6 high severity vulnerabilities. Currently no fix available for that.