Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #152

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Update dependencies #152

merged 1 commit into from
Jan 19, 2022

Conversation

kr8n3r
Copy link
Contributor

@kr8n3r kr8n3r commented Jan 19, 2022

What

Updates:

  • sass
  • rollup
  • npm min version

How to test

  • clone branch
  • install updated dependencies (npm install)
  • build the site (npm run build)
  • cd into out folder and serve the page (npx serve)
  • check page on localhost:5000 for any issues

There are expected warnings in CSS compilation coming from govuk-frontend

npm install will output 6 high severity vulnerabilities. Currently no fix available for that.

@kr8n3r
Update dependencies
c1f51aa 
- sass
- rollup
- npm min version
cadmiumcat
cadmiumcat approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@cadmiumcat cadmiumcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I had a click around, but are there any specific issues I should check for?
If not, I'm happy 🙌

@kr8n3r kr8n3r merged commit 3007ed5 into main Jan 19, 2022
@kr8n3r kr8n3r deleted the update-dependencies branch January 19, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadmiumcat cadmiumcat cadmiumcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kr8n3r @cadmiumcat