Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #165

Merged
merged 1 commit into from
May 12, 2022
Merged

Update dependencies #165

merged 1 commit into from
May 12, 2022

Conversation

kr8n3r
Copy link
Contributor

@kr8n3r kr8n3r commented May 12, 2022

Bump

Major

  • Jest
  • standard
  • @rollup/plugin-commonjs

Minor

  • sass
  • @rollup/plugin-node-resolve
  • rollup

Patch

  • next
  • next-mdx-remote
  • postcss
  • typescript

Remove

  • @next/mdx

Add

  • jest-environment-jsdom as it's not include with Jest28

How to test

  • clone branch
  • install updated dependencies (npm install)
  • build the site (npm run build)
  • cd into out folder and serve the page (npx serve)
  • check page on localhost:5000 for any issues

There are expected warnings in CSS compilation coming from govuk-frontend

1) Bump

Major
- Jest
- standard
- @rollup/plugin-commonjs

Minor
- sass
- @rollup/plugin-node-resolve
- rollup

Patch
- next
- next-mdx-remote
- postcss
- typescript

2) Remove
 - @next/mdx

 3) Add
 - jest-environment-jsdom as it's not include with Jest28
Copy link
Member

@AP-Hunt AP-Hunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes match the description, and definitely all working locally.

@kr8n3r kr8n3r merged commit 68cfae3 into main May 12, 2022
@kr8n3r kr8n3r deleted the update-dependencies branch May 12, 2022 13:36
@kr8n3r kr8n3r added the dependencies Pull requests that update a dependency file label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants