Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular maintenance #168

Merged
merged 2 commits into from
May 30, 2022
Merged

Regular maintenance #168

merged 2 commits into from
May 30, 2022

Conversation

kr8n3r
Copy link
Contributor

@kr8n3r kr8n3r commented May 30, 2022

What

  • Regular dependency updates
  • Update import of govuk-frontend to accommodate move to EcmaScript Modules

How to test

  • review commits
  • tests pass
  • clone branch
  • install updated dependencies (npm install)
  • build the site (npm run build)
  • cd into out folder and serve the page (npx serve)
  • check page on localhost:xxxx for any issues

There are expected warnings in CSS compilation coming from govuk-frontend

- govuk-frontend to 4.1
- sass to 1.52.1
- @testing-library/react to 13.3.0
- postcss to 8.4.14
- rollup to 2.75.3
- typescript to 4.7.2
@kr8n3r kr8n3r added the dependencies Pull requests that update a dependency file label May 30, 2022
- change module import
- remove NodeListforEach import and replace with a For loop
Copy link
Contributor

@schmie schmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kr8n3r kr8n3r merged commit 7ec2209 into main May 30, 2022
@kr8n3r kr8n3r deleted the maintenance branch May 30, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants