-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PP-2696 Reinstate Transactions list with charges and refunds
- Add _@Transactional_ annotation to TransactionDao since this is causing issues, so PP-2515 can be added back: google/guice#730 - Reinstante PP-2515 Implementation of `TransactionDao` The implementation of `TransactionDao` is meant to be used a as drop-in replacement for `ChargeDao` when we want to take refunds into consideration while searching. - A transaction can be of two types `charge` or `refund`. Depending on whether we want to search for only charges or refunds, an optional payment type can be specified in the filtering criteria. The absence of a payment type in the search criteria implies all types are considered during the search. - The filtering criteria has been augmented to allow searching by refund status or charge status or any combination of both. - Technical note: Performance being an overriding concern when searching for transactions, the underlying query required to be hand-optimized in order to get a decent execution plan out of a SQL UNION with pagination. Since JPA tend to get in the way because of its lack of support for UNION query, we were forced to resort to using a native query constructed dynamically with the support of jOOQ's query DSL API. https://www.jooq.org/doc/3.9/manual/getting-started/use-cases/jooq-as-a-standalone-sql-builder/
- Loading branch information
Showing
12 changed files
with
1,704 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.