PP-12521 Products UI request and cypress dev dependency cleanup
#2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have recently replaced `request` with `axios` in Products UI.
With this change, we are now operating a cleanup of the dev dependencies to
stop `request` showing up in security alerts.
The latest v13 of Cypress no longer needs request-promise-native as a separate
dev dependency (it pulls in @cypress/request).
So we are now:
- removing the override for "request": { "qs": "6.11.1"}
- removing "request-promise-native": "^1.0.9"
- updating cypress to the latest v13.x version as Frontend (13.7.2at time of
writing)
Further information in JIRA
https://payments-platform.atlassian.net/browse/PP-12521
marcotranchino
force-pushed
the
mt-update-cypress
branch
from
66330ae
to
f21cc1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently replaced
requestwithaxiosin Products UI.With this change, we are now operating a cleanup of the dev dependencies to stop
requestshowing up in security alerts.The latest v13 of Cypress no longer needs request-promise-native as a separate dev dependency (it pulls in @cypress/request).
So we are now:
removing the override for "request": { "qs": "6.11.1"}
removing "request-promise-native": "^1.0.9"
updating cypress to the latest v13.x version as Frontend (13.7.2at time of writing)
Further information in JIRA
https://payments-platform.atlassian.net/browse/PP-12521