Skip unpublishing one smokey licence #1875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busking-licence is used in our smoke tests but Smokey can't be deployed currently due to chromedriver version issues. This means that we can't update smokey to point at the new busking-licence path (/find-licences/busking-licence) and thus Smokey would start failing if we unpublished the original licence. Temporary fix to leave the busking licence published while unpublishing all other licence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
busking-licence is used in our smoke tests but Smokey can't be deployed currently due to chromedriver version issues. This means that we can't update smokey to point at the new busking-licence path (/find-licences/busking-licence) and thus Smokey would start failing if we unpublished the original licence. Temporary fix to leave the busking licence published while unpublishing all other licence.
Follow these steps if you are doing a Rails upgrade.